QA Report

[code423n4]

QA report: ./contracts

contracts/Aura.sol

• (_amount != 0) check is missing in function mint (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/Aura.sol#L91)
• (_amount != 0) check is missing in function minterMint (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/Aura.sol#L128)

contracts/AuraBalRewardPool.sol

• Incorrect return value for function getReward() (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraBalRewardPool.sol#L189)
  • Boolean value true is returned even when reward == 0. Solution: move the return statement from line 189 to inside the if statement.

contracts/AuraMerkleDrop.sol

• Address 0 check missing in the setDao() function. Add the check require(_newDao != address(0),"Error message") to avoid incorrect address set for Dao. (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraMerkleDrop.sol#L77)
• Event in the claim() function is emitting the incorrect amount in case of a penalty being charged. When there is a penalty deduction, ensure that the exact amount withdrawn is emitted. (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraMerkleDrop.sol#L141)

contracts/ExtraRewardsDistributor.sol

• (_amount != 0) check is missing in _addReward() function. (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/ExtraRewardsDistributor.sol#L87)

contracts/AuraLocker.sol

• Event is emitted before token transfer in emergencyWithdraw() function. The event should be emitted after the transfer is completed. (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L352-L368)

contracts/AuraStakingProxy.sol

• Address 0 check is missing in the setRewards() function. Add the check require(_rewards != address(0),"Error message") (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraStakingProxy.sol#L137)

contracts/AuraVestedEscrow.sol

• Address 0 check is missing in setAdmin() function. Add the check `require(_admin != address(0), "Error message") (https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraVestedEscrow.sol#L77)