Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #216

Open
code423n4 opened this issue May 24, 2022 · 0 comments
Open

Gas Optimizations #216

code423n4 opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

> 0 IS LESS EFFICIENT THAN != 0 FOR UINT IN require STATEMENT

!=0 costs less gas than >0 for uint in require statement.

Proof: While it may seem that >0 is cheaper than !=, this is only true if the optimizer is enabled and declared outside the require statement. If you enable the optimizer at 10k and declare it in require statement, this will save gas. you can see this tweet for more proof:
https://twitter.com/gzeon/status/1485428085885640706

I suggest to changing >0 with !=0 here (and also enable the optimizer):

https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L210
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L259
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L359
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L385
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L431
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L471
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraLocker.sol#L851
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraBalRewardPool.sol#L139
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraBalRewardPool.sol#L210
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/Aura.sol#L68
https://github.com/code-423n4/2022-05-aura/blob/main/contracts/AuraVestedEscrow.sol#L118

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 24, 2022
code423n4 added a commit that referenced this issue May 24, 2022
@0xMaharishi 0xMaharishi added the duplicate This issue or pull request already exists label May 27, 2022
@dmvt dmvt removed the duplicate This issue or pull request already exists label Jul 8, 2022
@dmvt dmvt mentioned this issue Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

3 participants