QA Report

[code423n4]

QA Report

Remarks/Recommendations

• epoch always seems to be an even multiple of rewardsDuration = 7 * 86400. However, it would probably be better to just have an epoch number. A lot of the arithmetic would be simplified this way. Any time you need to compare against the epoch start time you could just multiply by 86400*7.

Non-critical: Consider removing simple AuraMath functions

Functions in AuraMath like add and sub have been reimplemented to take advantage of Solidity 0.8.x's over/underflow checking. But calling these functions is sure to cost more gas than simply performing the arithmetic. Consider removing the functions and just inlining the code at all the locations in the code where you use them.

Non-critical: Move require in AuraMerkleDrop.forwardPenalty to constructor

Since penaltyForwarder is immutable just move require(penaltyForwarder != address(0), "!forwarder"); at AuraMerkleDrop.sol:152 to the constructor

[0xMaharishi]

code-423n4/2022-05-aura#6