Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #41

Open
code423n4 opened this issue May 14, 2022 · 2 comments
Open

QA Report #41

code423n4 opened this issue May 14, 2022 · 2 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Code Quality Report

[Low-01] Add a timelock

It is good to have a timelock for functions that set key/critical variables.

[Low-02] Loss of precision

Doing multiplication before the divisions leads to better precision.

[Low-03] Change owner with two steps verification process

Consider having two steps verification to change owner to avoid human errors. The following contracts use direct transfer.

[Low-04] Fee parameter should be in a certain range

Some fee parameters of functions are not checked for invalid values. The fee parameter should not exceed 100%.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 14, 2022
code423n4 added a commit that referenced this issue May 14, 2022
@code423n4
sokirico issue #41
faa7f73
@phijfry
Copy link
Collaborator

phijfry commented May 25, 2022

"Some fee parameters of functions are not checked for invalid values. The fee parameter should not exceed 100%." I don't understand this. The fee parameter is an address, not sure how it can exceed 100% or what that means. The other suggestion here are dupes .

@0xMaharishi 0xMaharishi added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label May 25, 2022
@0xMaharishi
Copy link

dupe

liveactionllama added a commit that referenced this issue Jun 23, 2022
@liveactionllama
sikorico issue #41
7d77f10 
Correcting warden name from `sokirico` to `sikorico`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @0xMaharishi @phijfry