Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #194

Open
code423n4 opened this issue Jun 3, 2022 · 2 comments
Open

QA Report #194

code423n4 opened this issue Jun 3, 2022 · 2 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Title: Set amount to 1, to minimize error
https://github.com/code-423n4/2022-05-opensea-seaport/blob/main/contracts/lib/Executor.sol#L81

we can set this value constantly as 1, there is no need that this value should be dynamically set, since the _transferERC721() will check if the amount value is 1, and we can remove this check to make it cheaper overall

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 3, 2022
code423n4 added a commit that referenced this issue Jun 3, 2022
@0age 0age added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Jun 3, 2022
@0age
Copy link
Collaborator

0age commented Jun 3, 2022

using a constant here, and not the actual value, introduces a vulnerability where a single 721 is transferred but multiple items are expected

@HardlyDifficult
Copy link
Collaborator

Merging with #190

Reopening as with this there is now 1 valid low.

@HardlyDifficult HardlyDifficult removed the invalid This doesn't seem right label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Development

No branches or pull requests

3 participants