QA Report

[code423n4]

LOW

L-01: Outdated compiler version (pragma solidity 0.6.12)

Older compilers might be susceptible to some bugs.

I recommend changing the solidity version pragma to the latest version to enforce the use of an up-to-date compiler.

A list of known compiler bugs and their severity can be found here: https://etherscan.io/solcbuginfo

L-02: Unsafe approve

YieldManager.sol#L221

The ERC20.approve() function returns a boolean value indicating success.
This parameter needs to be checked for success.

I recommend using OpenZeppelin’s safeApprove function that handle the return value check as it was done it the other contracts.

NON-CRITICAL

N-01: safeApprove has been deprecated

ConvexCurveLPVault.sol#L158

LidoVault.sol#L102

Consider using safeIncreaseAllowance and safeDecreaseAllowance instead.

REFERENCE

[HickupHH3]

low: safeApprove, unsafe approve
nc: outdated compiler version