Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Q -> H from 69 [1654495749150] #169

Closed
code423n4 opened this issue Jun 6, 2022 · 2 comments
Closed

Upgraded Q -> H from 69 [1654495749150] #169

code423n4 opened this issue Jun 6, 2022 · 2 comments
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #69 as High risk. The relevant finding follows:

@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working upgraded by judge labels Jun 6, 2022
code423n4 added a commit that referenced this issue Jun 6, 2022
@HickupHH3 HickupHH3 added the duplicate This issue or pull request already exists label Jun 6, 2022
@HickupHH3
Copy link
Collaborator

  1. Slippage of 1% is too strict
    The GeneralVault assumes that st tokens are always 1:1 redeemable and therefore the slippage should be negligable. This currently is not the case, specifically for LIDO where the depegging is >4%.

@HickupHH3
Copy link
Collaborator

HickupHH3 commented Jun 6, 2022

Duplicate of #133

I'm being lenient here as one might argue that the critical step of linking the slippage check of GeneralVault to causing stuck user fund withdrawals was not made. It just happens to be that the LIDO vault was an exception, where users can withdraw directly in stETH, as the warden has reasoned, so I will give the warden the benefit of the doubt this time.

@HickupHH3 HickupHH3 marked this as a duplicate of #133 Jun 6, 2022
@HickupHH3 HickupHH3 added invalid This doesn't seem right and removed invalid This doesn't seem right labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Development

No branches or pull requests

2 participants