Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Q -> H from 135 [1654503748167] #174

Closed
code423n4 opened this issue Jun 6, 2022 · 1 comment
Closed

Upgraded Q -> H from 135 [1654503748167] #174

code423n4 opened this issue Jun 6, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #135 as High risk. The relevant finding follows:

@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working upgraded by judge labels Jun 6, 2022
code423n4 added a commit that referenced this issue Jun 6, 2022
@HickupHH3
Copy link
Collaborator

HickupHH3 commented Jun 6, 2022

Duplicate of #133.

"At LidoVault.sol, the slippage is hardcoded to 200 inside swapExactTokensForTokens() which yields to %2 and it most likely will revert during volatile market conditions and it will not be possible to save economic value of the assets by not being able to withdraw ETH."

Again, I am being lenient here because the warden should've substantiated more by pointing to recent market conditions of ETH / stETH rates, and refer to the 1% slippage in the general vault as another cause of failure of fund withdrawals. One can argue that the guideline of "demonstrating proper theory of how an issue could be exploited" was not met. However, the warden did point out the impact of failing withdrawals.

In the interest of fairness of my leniency for other issues raised, I will let this pass.

@HickupHH3 HickupHH3 added the duplicate This issue or pull request already exists label Jun 6, 2022
@HickupHH3 HickupHH3 mentioned this issue Jun 8, 2022
@HickupHH3 HickupHH3 added invalid This doesn't seem right and removed invalid This doesn't seem right labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Development

No branches or pull requests

2 participants