QA Report #265
Labels
bug
Something isn't working
invalid
This doesn't seem right
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
It can be seen as an edge case when the reward to notify via the BaseRewardPool is lower than the seconds in a week, It won't likely happen with a reward token with 18 decimals, instead with a 6 decimals token, like the sanUSDC_EUR LP token collected from the angle FeeDistributor contract, this scenario could be present in the first week/s when the ANGLE locked amount could be really low.
Within the
notifyRewardAmount
when it calculated therewardRate
, if thereward
is <duration
therewardRate
should be equal to 0, and the reward would be lost.It can happen, for example with a 6 decimals tokens, when the reward to notify is < 0.604800 (604800 seconds in a week).
It could happen if the reward would be notified to the
BaseRewardPool
. This pool can support reward token with any decimal, but keep in mind that maybe other reward pool contract could be adapted to support reward token with decimals different than 18.The text was updated successfully, but these errors were encountered: