Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from 268 [1659038665057] #277

Closed
code423n4 opened this issue Jul 28, 2022 · 1 comment
Closed

Upgraded Q -> M from 268 [1659038665057] #277

code423n4 opened this issue Jul 28, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

code423n4 commented Jul 28, 2022 •
edited by JeeberC4
Loading

Judge has assessed an item in Issue #268 as Medium risk. The relevant finding follows:

The protocol does not support fee on transfer and other weird tokens, e.g.:

IERC20(_rewardToken).safeTransferFrom(msg.sender, address(this), _amount);
rewardTokenInfo[_rewardToken].queuedRewards += _amount;
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge labels Jul 28, 2022
code423n4 added a commit that referenced this issue Jul 28, 2022
@code423n4
Upgrade for pauliax issue #277
0415020
@JeeberC4
Copy link

Duplicate of #190

@JeeberC4 JeeberC4 marked this as a duplicate of #190 Jul 28, 2022
@JeeberC4 JeeberC4 added the duplicate This issue or pull request already exists label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @JeeberC4