Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #178

Open
code423n4 opened this issue Jun 19, 2022 · 2 comments
Open

QA Report #178

code423n4 opened this issue Jun 19, 2022 · 2 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

code423n4 commented Jun 19, 2022 •
edited by 0xleastwood
Loading

Missing validation for the return value of the price oracle

Lines of code

https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/helpers/ConnextPriceOracle.sol#L125

Vulnerability details

Impact

Tprice feed must be checked if the data is really updated or not.

Proof of Concept

https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/helpers/ConnextPriceOracle.sol#L125

Tools Used

code review

Recommended Mitigation Steps

Add the following validations.

(uint80 roundId, uint256 answer, , uint256 updatedAt, uint80 answeredInRound) = oracle.latestRoundData();

require(answeredInRound >= roundId, "error message");
require(updatedAt > 0, "error message");
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jun 19, 2022
code423n4 added a commit that referenced this issue Jun 19, 2022
@code423n4
kenta issue #178
6e226a2
@ecmendenhall
Copy link

Duplicate of #190

@jakekidd
Copy link
Collaborator

dup #190

@jakekidd jakekidd added the duplicate This issue or pull request already exists label Jun 24, 2022
@0xleastwood 0xleastwood changed the title Missing validation for the return value of the price oracle QA Report Aug 12, 2022
@0xleastwood 0xleastwood added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed duplicate This issue or pull request already exists 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Aug 12, 2022
@0xleastwood 0xleastwood reopened this Aug 12, 2022
@0xleastwood 0xleastwood mentioned this issue Aug 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ecmendenhall @jakekidd @0xleastwood @code423n4