Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #43

Closed
code423n4 opened this issue Jun 12, 2022 · 1 comment
Closed

QA Report #43

code423n4 opened this issue Jun 12, 2022 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

  • BridgeFacet.sol#L252: In contrast to the other setters, it is not checked if the address is a contract
  • NomadFacet.sol#L26: Missing check for 0 address / check if the address is a contract
  • LibDiamond.sol#L145: As functions are replaced there, this can't / should never happen, so it is advisable to include a check for it instead of adding the facet in such a case.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 12, 2022
code423n4 added a commit that referenced this issue Jun 12, 2022
@code423n4
Lambda issue #43
84e77cb
@jakekidd
Copy link
Collaborator

jakekidd commented Jul 1, 2022 •
edited
Loading

none are valid issues unfortunately:

  • Valid to set address(0) for this (if no sponsor vault applies)!
  • This is functionally checked at runtime; if it's not set, xcalls are reverted. For multi-step deployments, this is ok
  • Facet addresses are not the same; this issue isn't making sense to me

@jakekidd jakekidd added the invalid This doesn't seem right label Jul 1, 2022
@0xleastwood 0xleastwood mentioned this issue Aug 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakekidd @0xleastwood @code423n4