Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #80

Open
code423n4 opened this issue Jun 14, 2022 · 0 comments
Open

QA Report #80

code423n4 opened this issue Jun 14, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

L: Unresolved TODO's

The following lines of code contain unresolved commented TODO's that must be reviewed, deleted or implemented depending each case.

It is important to remark that by developing the implementations pointed by those to do's; their logics, possible impacts and plausible attack vectors associated that could happen will require further audits to determine if they convey or not further risks.

BridgeFacet.sol L:492

BridgeFacet.sol L:579

BridgeFacet.sol L:1027

LibConnextStorage.sol L:303

UpgradeBeaconController.sol
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 14, 2022
code423n4 added a commit that referenced this issue Jun 14, 2022
@code423n4
0xNineDec issue #80
c489835
@0xleastwood 0xleastwood mentioned this issue Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4