Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADMIN SETUP SHOULD BE A TWO STEP PROCESS #105

Closed
code423n4 opened this issue Jun 25, 2022 · 1 comment
Closed

ADMIN SETUP SHOULD BE A TWO STEP PROCESS #105

code423n4 opened this issue Jun 25, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working invalid This doesn't seem right sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/marketplace/MarketPlace.sol#L109
https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/lender/Lender.sol#L129
https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L62

Vulnerability details

Impact

The MarketPlace.setAdmin(), Lender.setAdmin() & Redeemer.setAdmin() logic should be a two step process (one function to propose and another one to adopt) in order to prevent losing unexpectedly the ownership of the contract. If the ownership is lost somehow, there is no way to claim it back and the whole functioning of the protocol will be compromised.

Recommended Mitigation Steps

Regarding the implementation itself and further communications:

  • It is advisable to check that the proposed address is not the address(0)
  • It is important to communicate the community how will be the ownership managed (EOA, Multisig, external protocol vault contract, etc) in order to generate transparency.
  • Using a timelock to change ownership could help also for the transparency of ownership management.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jun 25, 2022
code423n4 added a commit that referenced this issue Jun 25, 2022
@code423n4
0xNineDec issue #105
7b2e724
@sourabhmarathe sourabhmarathe added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Jun 29, 2022
@sourabhmarathe
Copy link
Collaborator

Duplicate of #316.

@sourabhmarathe sourabhmarathe mentioned this issue Jun 30, 2022
Closed
@gzeoneth gzeoneth added the invalid This doesn't seem right label Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working invalid This doesn't seem right sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sourabhmarathe @code423n4 @gzeoneth