Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users can't receive back underlying tokens when they redeem. #164

Closed
code423n4 opened this issue Jun 25, 2022 · 1 comment
Closed

Users can't receive back underlying tokens when they redeem. #164

code423n4 opened this issue Jun 25, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-06-illuminate/blob/92cbb0724e594ce025d6b6ed050d3548a38c264b/redeemer/Redeemer.sol#L128

Vulnerability details

Impact

Users can't receive back underlying tokens when they redeem.

Proof of Concept

Like the above comment, this function is designed to transfer underlying token to the user, but it transfers to Redeemer contract.

Tools Used

Solidity Visual Developer of VSCode

Recommended Mitigation Steps

Modification for transfer logic.

Safe.transferFrom(IERC20(u), lender, msg.sender, amount);
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Jun 25, 2022
code423n4 added a commit that referenced this issue Jun 25, 2022
@code423n4
hansfriese issue #164
6bebb7c
@sourabhmarathe sourabhmarathe added duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Jun 29, 2022
@sourabhmarathe
Copy link
Collaborator

Duplicate of #384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sourabhmarathe @code423n4 @gzeoneth