Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High: Original underlying token is not transferred back to the user #177

Closed
code423n4 opened this issue Jun 25, 2022 · 1 comment
Closed

High: Original underlying token is not transferred back to the user #177

code423n4 opened this issue Jun 25, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-06-illuminate/blob/217ddfef05bc9df5c7b94f1c3226a46ee136b57d/redeemer/Redeemer.sol#L128

Vulnerability details

Impact

In redeem, the original underlying token should be transferred back to the user when an iPT is redeemed. But the target of the transfer is actually address(this), i.e. the Redeemer.

Recommended Mitigation Steps

Transfer the original underlying token to the user, as it is intended.
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Jun 25, 2022
code423n4 added a commit that referenced this issue Jun 25, 2022
@code423n4
Lambda issue #177
aa51166
@sourabhmarathe sourabhmarathe added duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Jun 29, 2022
@sourabhmarathe
Copy link
Collaborator

Duplicate of #384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sourabhmarathe @code423n4 @gzeoneth