Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeemer.redeem() for Illuminate doesn't send the asset to the user. #181

Closed
code423n4 opened this issue Jun 25, 2022 · 1 comment
Closed

Redeemer.redeem() for Illuminate doesn't send the asset to the user. #181

code423n4 opened this issue Jun 25, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-06-illuminate/blob/92cbb0724e594ce025d6b6ed050d3548a38c264b/redeemer/Redeemer.sol#L128

Vulnerability details

Impact

Redeemer.redeem() for Illuminate doesn't send the asset to the user.
The user might lose his underlying asset.

Proof of Concept

This function should transfer the asset to the user but it transfers to the contract.

Tools Used

Manual Review

Recommended Mitigation Steps

Modify Safe.transferFrom(IERC20(u), lender, address(this), amount); like this.

Safe.transferFrom(IERC20(u), lender, msg.sender, amount);
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Jun 25, 2022
code423n4 added a commit that referenced this issue Jun 25, 2022
@code423n4
auditor0517 issue #181
2f0e5ea
@sourabhmarathe
Copy link
Collaborator

Duplicate of #384.

@sourabhmarathe sourabhmarathe added duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sourabhmarathe @code423n4 @gzeoneth