Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #378

Open
code423n4 opened this issue Jun 26, 2022 · 0 comments
Open

QA Report #378

code423n4 opened this issue Jun 26, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Typos


marketplace/MarketPlace.sol: L11

/// @notice This contract is in charge of managing the avaialable principals for each loan market.

Change avaialable to avaialable


marketplace/MarketPlace.sol: L34

    /// @notice The principal tokens those addresses represent correspond to their Principals enum value, thus the array should be ordered in that way

Change those addresses represent to whose addresses


marketplace/MarketPlace.sol: L50

    /// @notice intializes the MarketPlace contract

Change intializes to initializes


lender/Lender.sol: L6

import './MarketPlace.sol'; // library of market place specific constructs

Change market place to marketplace


lender/Lender.sol: L83

        // max is the maximum integer value for a 256 unsighed integer

Change unsighed to unsigned


The same typo (gauruntee) occurs in both lines referenced below:

lender/Lender.sol: L500
lender/Lender.sol: L504

Example:

        if (token.underlying() != u) { // gauruntee the input token is the right token

Change gauruntee to guarantee in both cases


lender/Lender.sol: L650

        // send the remaing amount to the given yield pool

Change remaing to remaining


lender/Lender.sol: L679

    /// @return uint256 The total for for the given amount

Remove the repeated word for


The same typo (prinicipal) occurs in both lines referenced below:

redeemer/Redeemer.sol: L125
redeemer/Redeemer.sol: L189

Example:

            // Burn the prinicipal token from Illuminate

Change prinicipal to principal in both cases


redeemer/Redeemer.sol: L237

    /// @param d Sense contract that splits the loan's prinicpal and yield

Change prinicpal to principal


redeemer/Redeemer.sol: L273

    /// @param a amount of the underlying asset to be burned and sent to the to

Replaceto the to with to the t address


Comments referring to unfinished work or open items

Such comments should be addressed and modified or removed


lender/Lender.sol: L561

        // Potentially add redundant implied maturity calculation

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 26, 2022
code423n4 added a commit that referenced this issue Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant