Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #380

Open
code423n4 opened this issue Jun 26, 2022 · 0 comments
Open

QA Report #380

code423n4 opened this issue Jun 26, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

[NC - 01] - Readability could be improved when taking max value of a type

Here, since Solidity 0.8.8, you can use type(uint256).max.

Check https://github.com/ethereum/solidity/blob/develop/Changelog.md#088-2021-09-27

[NC - 02] - Typo

Here, avaialable -> available

[NC - 03] - Typo

Here, prinicipal -> principal

[NC - 04] - Use readable variable names

The code interact with various protocols and is already quite complicated, no need to obfuscate it with unreadable variable names such as u, n, m,

[L - 01] - Redeem does not behave as explained in the comments

https://github.com/code-423n4/2022-06-illuminate/blob/912be2a90ded4a557f121fe565d12ec48d0c4684/redeemer/Redeemer.sol#L128

When redeeming Illuminate's token, the underlying is not sent back to the user, like said in the previous comment. So reading this function code is misleading and may lead to a user calling it.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 26, 2022
code423n4 added a commit that referenced this issue Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant