Not follow the WP

[code423n4]

Lines of code

https://github.com/code-423n4/2022-06-infinity/blob/601e0e5498587f5b1ae33f345223c86526ae9ce1/contracts/token/InfinityToken.sol#L55
https://github.com/code-423n4/2022-06-infinity/blob/601e0e5498587f5b1ae33f345223c86526ae9ce1/contracts/token/InfinityToken.sol#L122
https://github.com/code-423n4/2022-06-infinity/blob/601e0e5498587f5b1ae33f345223c86526ae9ce1/contracts/token/InfinityToken.sol#L76
https://github.com/code-423n4/2022-06-infinity/blob/601e0e5498587f5b1ae33f345223c86526ae9ce1/contracts/token/InfinityToken.sol#L134

Vulnerability details

Impact

There are discrepancies between the token logic found in the readme and the implemented logic.

Proof of Concept

The description of the contract mentions:

Initial supply will be 250M

However, this restriction is not specified in the code.

Affected source code:

• InfinityToken.sol#L55

There is a max supply of 1B tokens. Initial supply will be 250M. There are 3 inflation epochs, each with a time gap of 6 months. Each inflation epoch adds 250M tokens to the supply. After 1B max supply is reached there won't be any more supply unless the max number of epochs is increased`

However, this restriction is not specified in the code, since the values depend on configurations controlled by the owner that can be modified at any time (like EPOCH_INFLATION).

Affected source code:

• InfinityToken.sol#L122
• InfinityToken.sol#L76
• InfinityToken.sol#L134

Recommended Mitigation Steps

• Make sure the WP is complied with in the code.

[nneverlander]

Thanks

[HardlyDifficult]

Merging with the warden's QA report #16