Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #13

Closed
code423n4 opened this issue Jun 16, 2022 · 2 comments
Closed

QA Report #13

code423n4 opened this issue Jun 16, 2022 · 2 comments
Assignees
@obatirou
Labels
bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/operators/Yearn/YearnCurveVaultOperator.sol#L48

When assigning values to 'address' state variables, a check for a 0x0 address should be implemented. Although numerous checks are present for other 'address' state variables, no check could be found for the assignment of '_eth' to 'eth'
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 16, 2022
code423n4 added a commit that referenced this issue Jun 16, 2022
@code423n4
nxrblsrpr issue #13
708f942
@obatirou obatirou self-assigned this Jun 17, 2022
@Yashiru
Copy link
Collaborator

Yashiru commented Jun 24, 2022

QA Report (Duplicated)

Duplicated of #61 at 2. Missing address(0) checks

@Yashiru Yashiru added the duplicate This issue or pull request already exists label Jun 24, 2022
@JeeberC4
Copy link

JeeberC4 commented Jul 5, 2022

Warden submitted multiple QA Reports. Will not be judged.

@JeeberC4 JeeberC4 closed this as completed Jul 5, 2022
@JeeberC4 JeeberC4 added the invalid This doesn't seem right label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obatirou obatirou

Labels
bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Yashiru @code423n4 @obatirou @JeeberC4