Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #98

Open
code423n4 opened this issue Jun 18, 2022 · 2 comments
Open

QA Report #98

code423n4 opened this issue Jun 18, 2022 · 2 comments
Assignees
@maximebrugel
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

Withdrawer.sol

  • L26 - The withdraw() function requires an approve from the WETH contract, it sounds strange that a withdraw() function requires an approve, therefore it would be easier to understand for a user with another name.

BeefyVaultStorage.sol

  • L5 - IERC20 is imported but not used.

StakingLPVaultHelpers.sol

  • L4 - Withdrawer is imported but not used.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 18, 2022
code423n4 added a commit that referenced this issue Jun 18, 2022
@code423n4
fatherOfBlocks issue #98
f9dc28f
@maximebrugel maximebrugel self-assigned this Jun 21, 2022
@obatirou
Copy link
Collaborator

Withdrawer.sol - L26 (disputed)

Disagree, we want to withdraw from the WETH contract, and a lot of withdraw functions need an approval.

@obatirou obatirou mentioned this issue Jun 27, 2022
Open
@obatirou
Copy link
Collaborator

L4 - Withdrawer is imported but not used (duplicate)

Duplicate #40 (comment)

L5 - IERC20 is imported but not used (duplicate)

Duplicate #40 (comment)

@obatirou obatirou added the duplicate This issue or pull request already exists label Jun 27, 2022
@JeeberC4 JeeberC4 removed the duplicate This issue or pull request already exists label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximebrugel @code423n4 @jack-the-pug @obatirou @JeeberC4