Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #224

Open
code423n4 opened this issue Jun 14, 2022 · 1 comment
Open

Gas Optimizations #224

code423n4 opened this issue Jun 14, 2022 · 1 comment
Labels

Comments

@code423n4
Copy link
Contributor

[Gas - 01] - Settling of account could be saved locally

https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/notional-wrapped-fcash/contracts/wfCashLogic.sol#L221

After maturation, each time someone burns, an external call NotionalV2.settleAccount(address(this)); is made. Even if it's a noop, it would be cheaper to have a local variable to store this and eventually skip the call as it needs to be done only once.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jun 14, 2022
code423n4 added a commit that referenced this issue Jun 14, 2022
@jeffywu
Copy link
Collaborator

jeffywu commented Jun 16, 2022

Good call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants