New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #409

Open

code423n4 opened this issue Jul 4, 2022 · 0 comments

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Jul 4, 2022

Caching array length can save gas
Caching the array length is more gas efficient.
This is because access to a local variable in solidity is more efficient than query storage / calldata / memory

**Occurrences in:
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L556
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L594
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L611
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L627
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L637
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L647
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L658
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L670
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L728
https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L742

The following variables should be cached to save gas
floorAssetTokenIds in fillOrder()
floorAssetTokenIds in exercise()

The text was updated successfully, but these errors were encountered:

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          cryptphi issue #409

909cab1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment