Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from 239 [1661780295145] #291

Closed
code423n4 opened this issue Aug 29, 2022 · 2 comments
Closed

Upgraded Q -> M from 239 [1661780295145] #291

code423n4 opened this issue Aug 29, 2022 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge Original issue severity upgraded from QA/Gas by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #239 as Medium risk. The relevant finding follows:
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge Original issue severity upgraded from QA/Gas by judge labels Aug 29, 2022
code423n4 added a commit that referenced this issue Aug 29, 2022
@code423n4
Upgrade for 0xsolstars issue #291
5f513eb
@HickupHH3
Copy link
Collaborator

Issue #1: OpenZeppelin recommends the usage of _safeMint() instead of _mint() since safeMint() checks whether a contract can handle ERC721 tokens. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/2dc086563f2e51620ebc43d2237fc10ef201c4e6/contracts/token/ERC721/ERC721.sol#L270

If the user provides an address that can't handle ERC721 tokens when calling any of the corresponding mint functions the minted token might be lost which could potentially result in the user not being able to redeem the nft anymore.

@HickupHH3 HickupHH3 added the duplicate This issue or pull request already exists label Aug 29, 2022
@HickupHH3
Copy link
Collaborator

dup of #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge Original issue severity upgraded from QA/Gas by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @HickupHH3