QA Report #259
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
valid
Invalid signer are also accepted
Contract:
Disputes
Issue:
In case signature provided is invalid, SignatureDecoder.recoverKey will return with 0 address. The function still process this 0 address and creates a new dispute with 0 address owner
Recommendation:
Kindly add below check:
initialize can be called by any external user
Contract:
Disputes
Issue:
It seems that user can call the initialize function before owner has chance to do the same. This will initialize the homeFi variable incorrectly. Although this is not serious as Owner can immediately discard this contract but would be good to restrict this function
Recommendation:
Kindly allow only owner/deployer to call this function
The text was updated successfully, but these errors were encountered: