Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #269

Open
code423n4 opened this issue Aug 6, 2022 · 0 comments
Open

QA Report #269

code423n4 opened this issue Aug 6, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

UNUSED STATE VARIABLE SHOULD BE REMOVED

Impact - NON CRITICAL

File: contracts/Project.sol

line 60 : uint256 public constant override VERSION = 25000;

CONSTANTS SHOULD BE DEFINED RATHER THAN USING MAGIC NUMBERS

Impact - NON CRITICAL

File: contracts/libraries/SignatureDecoder.sol

line 25 : if (messageSignatures.length % 65 != 0)
line 35 : if (v != 27 && v != 28)
line 82 : if (v < 27)

PUBLIC FUNCTIONS NOT CALLED BY THE CONTRACT SHOULD BE DECLARED EXTERNAL INSTEAD

Impact - NON CRITICAL

File: contracts/Community.sol

line 700 : function isTrustedForwarder(address _forwarder) public view override(ERC2771ContextUpgradeable, ICommunity) returns (bool)

File: contracts/DebtToken.sol

line 82 : function decimals() public view virtual override returns (uint8)

File: contracts/Disputes.sol

line 187 : function isTrustedForwarder(address _forwarder) public view override(ERC2771ContextUpgradeable, ICommunity) returns (bool)

File: contracts/HomeFi.sol

line 264 : function isTrustedForwarder(address _forwarder) public view override(ERC2771ContextUpgradeable, ICommunity) returns (bool)

File: contracts/Project.sol

line 727 : function isTrustedForwarder(address _forwarder) public view override(ERC2771ContextUpgradeable, ICommunity) returns (bool)

File: contracts/ProjectFactory.sol

line 98 : function isTrustedForwarder(address _forwarder) public view override(ERC2771ContextUpgradeable, ICommunity) returns (bool)
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 6, 2022
code423n4 added a commit that referenced this issue Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Development

No branches or pull requests

2 participants