QA Report

[code423n4]

1. Confusing modifier name noChange():

In HomeFi.sol#L82 noChange modifier name is not coherent with previous modifier names, that say what is allowed (onlyAdmin and nonZero). According to the same logic, one should use mustChange.

2. Use of available modifier noChange():

In HomeFi.sol#L191 replace the check by the corresponding modifier noChange().

3. Unused/redundant code:

• In HomeFi.sol#L296 internal function mintNFT() with unused return.

• internal function _msgData() is never used (HomeFi.sol#L314 , Community.sol#L910)

• redundant casting of uint256 to uint256 at Project.sol#L200

4. Confusing natspec comment:

HomeFiProxy.sol#L32: comment

/// @dev mapping that maps contract initials with there implementation address

is confusing since the mapping points to the proxies and not the implementation addresses.

Same imprecision exists in natspec comment at HomeFiProxy.sol#L172.

5. One step ownership change

In HomeFiProxy.sol#L150 owner of proxyAdmin is changed through a single step procedure. This is a critical system parameter and it is recommended to implement a two-step change.