Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #361

Open
code423n4 opened this issue Aug 6, 2022 · 0 comments
Open

QA Report #361

code423n4 opened this issue Aug 6, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

Summary

Low

  1. L-1. Pragma directives olders than libraries used.
  2. L-2. Missing zero address validation

Low

1. L-1. Pragma directives olders than libraries used.

Description

The code is using the version 0.8.6 and there are libraries like openzepelling that use a more recent version 0.8.9.

Mitigation

Update the version of solidity to a more recent one at least 0.8.9.

Lines in the code

DebtToken.sol#L3
ProjectFactory.sol#L3
HomeFiProxy.sol#L3
Disputes.sol#L3
HomeFi.sol#L3
Project.sol#L3
Community.sol#L3
SignatureDecoder.sol#L3
Tasks.sol#L3

2. L-2. Missing zero address validation

Description

Detect missing zero address validation

Mitigation

Include check that the address is not zero

Lines in the code

HomeFi.sol#L119
Project.sol#L103

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 6, 2022
code423n4 added a commit that referenced this issue Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Development

No branches or pull requests

2 participants