Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstructured HomeFi Proxy Storage Collision. #9

Closed
code423n4 opened this issue Aug 2, 2022 · 1 comment
Closed

Unstructured HomeFi Proxy Storage Collision. #9

code423n4 opened this issue Aug 2, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/AudiusProject/audius-protocol/blob/6e853cc6b62e2730940bcdf9b6e345d93c71b09b/eth-contracts/contracts/AudiusAdminUpgradeabilityProxy.sol#L14

Vulnerability details

The ProxyAdmin Variable does not store on Random Storage Slot. This Causes Storage Collision between Proxy and Implementation contract.

https://docs.openzeppelin.com/upgrades-plugins/1.x/proxies#unstructured-storage-proxies

Impact

Creates Storage Collision on Proxy and Impl contra

Recommended Mitigation Steps

Assign Random storage slot to ProxyAdmin Variable. Refer to https://docs.openzeppelin.com/upgrades-plugins/1.x/proxies#unstructured-storage-proxies
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Aug 2, 2022
code423n4 added a commit that referenced this issue Aug 2, 2022
@code423n4
ch13fd357r0y3r issue #9
9920058
This was referenced Aug 6, 2022
Open
Closed
Open
@zgorizzo69
Copy link
Collaborator

in the case of audius the proxy was not using unstructured storage
we use TransparentUpgradeableProxy for OZ that uses _ADMIN_SLOT == bytes32(uint256(keccak256("eip1967.proxy.admin")) - 1)
and the HomeFiProxy is actually not a proxy ...

@zgorizzo69 zgorizzo69 added disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue labels Aug 8, 2022
@jack-the-pug jack-the-pug added the invalid This doesn't seem right label Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zgorizzo69 @code423n4 @jack-the-pug