Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #136

Open
code423n4 opened this issue Sep 8, 2022 · 0 comments
Open

QA Report #136

code423n4 opened this issue Sep 8, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 8, 2022 •
edited
Loading

Low

  • use a later solidity version

  • Description
    It's a better to use the latest compiler version. The actual compiled version is 0.8.11 (quite old) and the latest is 0.8.16.

  • Mitigation
    Update the version of solidity to 0.8.16.

https://github.com/code-423n4/2022-09-canto/blob/65fbb8b9de22cf8f8f3d742b38b4be41ee35c468/src/Swap/BaseV1-core.sol#L2
https://github.com/code-423n4/2022-09-canto/blob/65fbb8b9de22cf8f8f3d742b38b4be41ee35c468/src/Swap/BaseV1-periphery.sol#L3
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 8, 2022
code423n4 added a commit that referenced this issue Sep 8, 2022
@code423n4
0x040 issue #136
ad1efff
code423n4 added a commit that referenced this issue Sep 8, 2022
@code423n4
0x040 data for issue #136
1a575f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4