Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #3

Closed
code423n4 opened this issue Sep 7, 2022 · 1 comment
Closed

QA Report #3

code423n4 opened this issue Sep 7, 2022 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 7, 2022 •
edited
Loading

However sol ^0.8.0 is used, It is recommended to use SafeMath operations for Math in following one:

https://github.com/code-423n4/2022-09-canto/blob/6f98ffa7ec55c2ca03aa4cd2301503487f0c412d/src/Swap/BaseV1-core.sol#L451

https://github.com/code-423n4/2022-09-canto/blob/6f98ffa7ec55c2ca03aa4cd2301503487f0c412d/src/Swap/BaseV1-core.sol#L457

https://github.com/code-423n4/2022-09-canto/blob/6f98ffa7ec55c2ca03aa4cd2301503487f0c412d/src/Swap/BaseV1-core.sol#L515
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 7, 2022
code423n4 added a commit that referenced this issue Sep 7, 2022
@code423n4
ch13fd357r0y3r issue #3
1da3592
code423n4 added a commit that referenced this issue Sep 7, 2022
@code423n4
ch13fd357r0y3r data for issue #3
a8dfbb8
This was referenced Sep 14, 2022
Closed
Open
@0xean 0xean mentioned this issue Sep 14, 2022
Closed
@0xean
Copy link
Collaborator

0xean commented Sep 14, 2022

closing as invalid, see contest scope

@0xean 0xean closed this as completed Sep 14, 2022
@0xean 0xean added the invalid This doesn't seem right label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @code423n4