Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #181

Closed
code423n4 opened this issue Oct 12, 2022 · 1 comment
Closed

QA Report #181

code423n4 opened this issue Oct 12, 2022 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@code423n4
Copy link
Contributor

code423n4 commented Oct 12, 2022

Contracts BridgeEscrow,L2GraphToken,L1GraphTokenGateway,and can always be reinitialized

Affected contracts and lines of code

Recommended mitigation check

  • Add a modifier check or a bool variable is stored in storage, and stored as true at the first initialization, and only initializes the contract, only when it is set to false
  • If the intention is not to allow re-initialization every time, then a reinitialzation function should be implemented
bool interanal initialized;

modifier initialized {
   if(initialized) revert();
}
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Oct 12, 2022
code423n4 added a commit that referenced this issue Oct 12, 2022
code423n4 added a commit that referenced this issue Oct 12, 2022
@pcarranzav
Copy link

Dupe of #149 ?

@JeeberC4 JeeberC4 added invalid This doesn't seem right unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Development

No branches or pull requests

3 participants