Skip to content

Commit

Permalink
Report for issue #67 updated by RaymondFam
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Dec 29, 2022
1 parent 9708a9f commit bd4805e
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions data/RaymondFam-G.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,18 @@ Consider removing the unneeded if block to save gas both on contract deployment
- revert InsufficientAVAXForMinipoolCreation();
- }
```
In the light of this, the following code line and function may also be removed:

[File: ProtocolDAO.sol](https://github.com/code-423n4/2022-12-gogopool/blob/main/contracts/contract/ProtocolDAO.sol)

```diff
- 47: setUint(keccak256("ProtocolDAO.MinipoolMinAVAXStakingAmt"), 2_000 ether);

- 129: /// @notice The min AVAX staking amount that is required for creating a minipool
- 130: function getMinipoolMinAVAXStakingAmt() public view returns (uint256) {
- 131: return getUint(keccak256("ProtocolDAO.MinipoolMinAVAXStakingAmt"));
- 132: }
```
## Avoid comparing boolean expressions to boolean literals
Comparing a boolean value to a boolean literal incurs the `ISZERO` operation and costs more gas than using a boolean expression.

Expand Down

0 comments on commit bd4805e

Please sign in to comment.