Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #360

Closed
code423n4 opened this issue Jan 1, 2023 · 3 comments
Closed

QA Report #360

code423n4 opened this issue Jan 1, 2023 · 3 comments
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jan 1, 2023
code423n4 added a commit that referenced this issue Jan 1, 2023
code423n4 added a commit that referenced this issue Jan 1, 2023
C4-Staff added a commit that referenced this issue Jan 6, 2023
@GalloDaSballo
Copy link

01 UPGRADEABLE CONTRACT IS MISSING A __GAP[50] STORAGE VARIABLE TO ALLOW FOR NEW STORAGE VARIABLES IN LATER VERSIONS

R

02 REQUIRE() SHOULD BE USED INSTEAD OF ASSERT()

R

03 MISSING EVENTS FOR FUNCTIONS THAT CHANGE CRITICAL PARAMETERS

NC

04 INCLUDE RETURN PARAMETERS IN NATSPEC COMMENTS

NC

05 OPEN TODOS

NC

07 USE A MORE RECENT VERSION OF SOLIDITY

NC

08 FLOATING PRAGMA VERSION SHOULD NOT BE USED

NC

09 ADDING A RETURN STATEMENT WHEN THE FUNCTION DEFINES A NAMED RETURN VARIABLE, IS REDUNDANT

R

@GalloDaSballo
Copy link

3R 5NC

@c4-judge c4-judge closed this as completed Feb 3, 2023
@c4-judge c4-judge added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Feb 3, 2023
@c4-judge
Copy link
Contributor

c4-judge commented Feb 3, 2023

GalloDaSballo marked the issue as grade-c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Development

No branches or pull requests

3 participants