Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #65

Open
code423n4 opened this issue Dec 22, 2022 · 4 comments
Open

QA Report #65

code423n4 opened this issue Dec 22, 2022 · 4 comments
Labels
bug Something isn't working edited-by-warden grade-a Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Dec 22, 2022
code423n4 added a commit that referenced this issue Dec 22, 2022
@code423n4
RaymondFam issue #65
d79a7d4
code423n4 added a commit that referenced this issue Dec 22, 2022
@code423n4
RaymondFam data for issue #65
3c16a49
code423n4 added a commit that referenced this issue Dec 22, 2022
@code423n4
Report for issue #65 updated by RaymondFam
e3c84e9
code423n4 added a commit that referenced this issue Dec 23, 2022
@code423n4
Report for issue #65 updated by RaymondFam
199e211
code423n4 added a commit that referenced this issue Dec 25, 2022
@code423n4
Report for issue #65 updated by RaymondFam
b019b08
code423n4 added a commit that referenced this issue Dec 25, 2022
@code423n4
Report for issue #65 updated by RaymondFam
717ec0a
code423n4 added a commit that referenced this issue Dec 26, 2022
@code423n4
Report for issue #65 updated by RaymondFam
1a048b4
code423n4 added a commit that referenced this issue Dec 26, 2022
@code423n4
Report for issue #65 updated by RaymondFam
4c8f3f4
code423n4 added a commit that referenced this issue Dec 27, 2022
@code423n4
Report for issue #65 updated by RaymondFam
8d105a9
code423n4 added a commit that referenced this issue Dec 28, 2022
@code423n4
Report for issue #65 updated by RaymondFam
14576c4
code423n4 added a commit that referenced this issue Dec 28, 2022
@code423n4
Report for issue #65 updated by RaymondFam
6dc973f
code423n4 added a commit that referenced this issue Dec 28, 2022
@code423n4
Report for issue #65 updated by RaymondFam
4f36b3e
code423n4 added a commit that referenced this issue Dec 29, 2022
@code423n4
Report for issue #65 updated by RaymondFam
b023f2e
code423n4 added a commit that referenced this issue Dec 30, 2022
@code423n4
Report for issue #65 updated by RaymondFam
b8e14af
code423n4 added a commit that referenced this issue Dec 30, 2022
@code423n4
Report for issue #65 updated by RaymondFam
10638b3
C4-Staff added a commit that referenced this issue Jan 6, 2023
@C4-Staff
original risk added for issue #65
889a0f8
@GalloDaSballo
Copy link

GalloDaSballo commented Jan 24, 2023 •
edited
Loading

Open TODOs

NC

Modularity on import usages

NC

Inadequate NatSpec

NC

Typo mistakes

NC

5% annual calculated on a daily interval not fully precised

L

Hard coded initialization

Disputing as those are settings that can be set by the deployer and others can chose to use or not

Inexpedient ternary logic

NC

Custom contract pauser and resumer

L

Unusual multisig logic

TODO Dup 50%

Comments and codes mismatch

L

GGP token exchange

Disputing as the DAO will figure it out in a separate contract, for example Balancer BPT

GGP tokens circulated distributions

L

Missing use for delegationFee

R

No storage gap for upgradeable contracts

Disputing as it's the child contract

Variable assignment in conditional checks

R

Zero value check on `withdrawAVAX() in TokenggAVAX.sol

R

Parameterized custom errors

R

bytes32 over bytes

I don't think this is valid, the key is a word the result may be bigger

Empty blocks

Disagree

This was referenced Jan 31, 2023
Closed
Closed
Closed
Closed
@GalloDaSballo
Copy link

3L from dups

4L 4R 5NC

@GalloDaSballo
Copy link

7L 4R 5NC

@c4-judge
Copy link
Contributor

c4-judge commented Feb 3, 2023

GalloDaSballo marked the issue as grade-a

@C4-Staff C4-Staff added the Q-09 label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden grade-a Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GalloDaSballo @code423n4 @c4-judge @C4-Staff