DOS function inflate() if inflationIntervalsElapsed is too large

[code423n4]

Lines of code

https://github.com/code-423n4/2022-12-gogopool/blob/aec9928d8bdce8a5a4efe45f54c39d4fc7313731/contracts/contract/RewardsPool.sol#L74

Vulnerability details

Impact

Whenever working with for loop on EVM, gas consumption should be taken care. If the loop is unbounded, it can consume gas even more than block gas limit and effectively DOS the functionality.

It is noticed that RewardsPool.getInflationAmt() calculate newTotalSupply by looping through inflationIntervalsElapsed. If it is too long since last update, inflationIntervalsElapsed can become too large and cause out of gas. Also, function getInflationAmt() is used in inflate() so inflate() will be DOS too.

Proof of Concept

Function getInflationAmt() used a unbounded loop

function getInflationAmt() public view returns (uint256 currentTotalSupply, uint256 newTotalSupply) {
    ProtocolDAO dao = ProtocolDAO(getContractAddress("ProtocolDAO"));
    uint256 inflationRate = dao.getInflationIntervalRate();
    uint256 inflationIntervalsElapsed = getInflationIntervalsElapsed();
    currentTotalSupply = dao.getTotalGGPCirculatingSupply();
    newTotalSupply = currentTotalSupply;

    // Compute inflation for total inflation intervals elapsed
    for (uint256 i = 0; i < inflationIntervalsElapsed; i++) { 
        // @audit out of gas if too long not update
        newTotalSupply = newTotalSupply.mulWadDown(inflationRate);
    }
    return (currentTotalSupply, newTotalSupply);
}

Tools Used

Manual Review

Recommended Mitigation Steps

Consider adding a constant max value for inflationIntervalsElapsed so it cannot get too large and cause DOS.

[GalloDaSballo]

Best because code snippet, but could have been improved via gas math or a test

[c4-judge]

GalloDaSballo marked the issue as primary issue

[emersoncloud]

duplicate of #132

[c4-judge]

GalloDaSballo marked the issue as partial-25

[0xju1ie]

dupe of #139

[c4-judge]

GalloDaSballo marked the issue as duplicate of #139

[c4-judge]

GalloDaSballo marked the issue as not a duplicate

[c4-judge]

Duplicate of #653

[GalloDaSballo]

L