Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #710

Open
code423n4 opened this issue Jan 3, 2023 · 3 comments
Open

QA Report #710

code423n4 opened this issue Jan 3, 2023 · 3 comments
Labels
bug Something isn't working grade-a Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jan 3, 2023
code423n4 added a commit that referenced this issue Jan 3, 2023
code423n4 added a commit that referenced this issue Jan 3, 2023
C4-Staff added a commit that referenced this issue Jan 6, 2023
@GalloDaSballo
Copy link

GalloDaSballo commented Jan 25, 2023

  1. Unused error messages:
    NC

  2. Allowed tokens are not easily inspectable by users
    NC

  3. Usage of += / -= for cleaner code
    Disagree due to gas

  4. Unused function `transferAvax``
    R

  5. Checks-effects-interaction pattern not respected
    L

  6. Non-zero validation for withdrawToken
    L

  7. Byte storage, int storage as well as the assigned setters are unused
    Disputing, they are used

  8. Non-zero validation missing for setGuardian
    NC as it cannot be accepted

  9. Unused import MinipoolManager
    NC

  10. Sub-optimal design for token inflation
    L

  11. Multisig reward distribution rounds down
    L

  12. Unused import: TokenGGP
    NC

  13. Missing non-zero validation for setOneInch
    L

  14. Users can not easily inspect the list of added Defenders
    NC

  15. avaxHalfRewards is rounded down
    50% of the time you lose 1 wei
    Disputed as there's subtraction to deal with dust later

5L 1R R 6NC

@GalloDaSballo
Copy link

3L from dups

8L 1R 6NC

@c4-judge
Copy link
Contributor

c4-judge commented Feb 3, 2023

GalloDaSballo marked the issue as grade-a

@C4-Staff C4-Staff added the Q-04 label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-a Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

4 participants