-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
10 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
### Manager can disable erInspectionMode when it's Cooldown is not completed | ||
## Summary | ||
use of wrong operator | ||
|
||
## Vulnerability Details | ||
https://github.com/code-423n4/2023-06-stader/blob/main/contracts/StaderOracle.sol#L187 | ||
Due to the use of the wrong operator (&& instead of ||), manager can still disable `erInspection Mode` even when it's Cooldown is not completed. Also when not in cooldown, absolutely anyone can still disable it due to the && operator | ||
|
||
## Recommendation: | ||
use || instead of &&. |