Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis #446

Open
code423n4 opened this issue Aug 10, 2023 · 10 comments
Open

Analysis #446

code423n4 opened this issue Aug 10, 2023 · 10 comments
Labels
A-06 analysis-advanced grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

code423n4 added a commit that referenced this issue Aug 10, 2023
code423n4 added a commit that referenced this issue Aug 10, 2023
@catellaTech
Copy link

Hello, while checking if the images in my analysis were uploaded correctly, I realized that I mistakenly placed quotation marks where I shouldn't have, and as a result, the diagram of a contract I worked hard on doesn't open. I kindly request the judge reviewing my analysis to consider this diagram

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label Aug 13, 2023
@c4-pre-sort
Copy link

141345 marked the issue as high quality report

@OpenCoreCH
Copy link

Great report! I especially like the diagram

@c4-sponsor c4-sponsor added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Aug 16, 2023
@c4-sponsor
Copy link

OpenCoreCH marked the issue as sponsor acknowledged

@c4-judge
Copy link

alcueca marked the issue as selected for report

@c4-judge c4-judge added selected for report This submission will be included/highlighted in the audit report grade-a labels Aug 22, 2023
@c4-judge
Copy link

alcueca marked the issue as grade-a

@c4-judge
Copy link

alcueca marked the issue as not selected for report

@c4-judge c4-judge removed the selected for report This submission will be included/highlighted in the audit report label Aug 22, 2023
@catellaTech
Copy link

Hi, @alcueca!! thanks for the great job... can u please can review again my analisys. All the diagrams now are good and the sponsor found value in my work 🤞

@alcueca
Copy link

alcueca commented Aug 30, 2023

The diagrams in this report are representative of the effort put into it. Additionally, sections 5 (Documents), 6 (Risks) and 7 (Security Approach) complete the report further by providing additional insight.

While the application description in #452 is more thorough and detailed, and should be reviewed by those exploring the codebase, this report offers more value for the sponsor, and is therefore selected for the report.

@c4-judge
Copy link

alcueca marked the issue as selected for report

@c4-judge c4-judge added the selected for report This submission will be included/highlighted in the audit report label Aug 30, 2023
@C4-Staff C4-Staff added the A-06 label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-06 analysis-advanced grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

8 participants