Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #435

Open
c4-submissions opened this issue Oct 20, 2023 · 4 comments
Open

Gas Optimizations #435

c4-submissions opened this issue Oct 20, 2023 · 4 comments
Labels
bug Something isn't working G (Gas Optimization) G-02 grade-a sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons sufficient quality report This report is of sufficient quality

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-submissions c4-submissions added bug Something isn't working G (Gas Optimization) labels Oct 20, 2023
c4-submissions added a commit that referenced this issue Oct 20, 2023
@c4-submissions
hihen issue #435
f054d24
c4-submissions added a commit that referenced this issue Oct 20, 2023
@c4-submissions
hihen data for issue #435
05aa1b5
@c4-pre-sort
Copy link

raymondfam marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Oct 22, 2023
@alex-ppg
Copy link

Optimizations of GAS-01 and GAS-04 are slightly incorrect as for 04 the uint32 data type is used to tightly pack the input payload whereas on GAS-01 the subtraction length - 8 - sigLength is potentially unsafe. In any case, I will label it as A for effort as well as partial validity of findings.

@c4-judge
Copy link

alex-ppg marked the issue as grade-a

@c4-sponsor
Copy link

0xad1onchain (sponsor) acknowledged

@c4-sponsor c4-sponsor added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Oct 28, 2023
@C4-Staff C4-Staff added the G-02 label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) G-02 grade-a sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@alex-ppg @c4-judge @c4-sponsor @c4-pre-sort @C4-Staff @c4-submissions