Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #2007

Closed
c4-submissions opened this issue Nov 13, 2023 · 6 comments
Closed

QA Report #2007

c4-submissions opened this issue Nov 13, 2023 · 6 comments
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-submissions c4-submissions added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 13, 2023
c4-submissions added a commit that referenced this issue Nov 13, 2023
c4-submissions added a commit that referenced this issue Nov 13, 2023
@141345
Copy link

141345 commented Nov 25, 2023

2007 0xepley
l r nc
2 0 3

L 1 l
L 2 i
L 3 n
L 4 n
L 5 l
L 6 n
L 7 d dup of #508
L 8 d dup of #179

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Nov 25, 2023
@c4-pre-sort
Copy link

141345 marked the issue as sufficient quality report

@alex-ppg
Copy link

alex-ppg commented Dec 8, 2023

QA Judgment

The Warden's QA report has been graded C based on a score of 13 combined with a manual review per the relevant QA guideline document located here.

The Warden's submission's score was assessed based on the following findings:

Low-Risk

Non-Critical

  • 1: Inexistent Check of Already Frozen Collection

However, upon manual re-evaluation, the Warden does not advise that the check should be non-inclusive / inclusive and simply advises a re-evaluation which would not highlight or fix the problem. As such, the final score of the submission is 3.

@c4-judge c4-judge closed this as completed Dec 8, 2023
@c4-judge c4-judge added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Dec 8, 2023
@c4-judge
Copy link

c4-judge commented Dec 8, 2023

alex-ppg marked the issue as grade-c

@Nabeel-javaid
Copy link

can you pls have another look at the above QA report as i'm not sure if your comments on this report are 100% correct

the QA report doesn't specify #1275 issue but have completely different issues

@alex-ppg
Copy link

alex-ppg commented Dec 9, 2023

Hey @Nabeel-javaid, thanks for requesting a follow-up review of this. Your number 6 submission was credited with a Low-Risk on an initial pass and upon manual review this score was removed which aligns with what you specified as you do not mention #1275, your recommendation is merely related to it.

All other QA submissions have been nullified per the relevant document referenced above. In detail:

  • 2: The error is not "incorrect", it is simply vague but sufficient in understanding what went wrong. Even so, this would contribute a 1 score to the overall report.
  • 3: This is a gas optimization.
  • 4: Using data types less than uint256 is ill-advised as it leads to gas increases.
  • 5: This is part of the bot report
  • 7: This is incorrect. As arrays are zero-index-based, an index of 0 matches the 1st element and an index of 99 matches the 100th element
  • 8: This is a preference, nothing prevents users from supplying hashes of off-chain data as the string arguments in case their payloads are too large

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Development

No branches or pull requests

6 participants