unchecked loop increments no valid in solidity > v0.8.22
#38
Labels
bug
Something isn't working
downgraded by judge
Judge downgraded the risk level of this issue
G (Gas Optimization)
G-12
grade-b
insufficient quality report
This report is not of sufficient quality
primary issue
Highest quality submission among a set of duplicates
Comments
c4-bot-7
added
2 (Med Risk)
c4-pre-sort
added
the
insufficient quality report
|
raymondfam marked the issue as insufficient quality report |
|
raymondfam marked the issue as primary issue |
c4-pre-sort
added
the
primary issue
|
It's meant for gas optimization. |
|
The lookout made a good point. |
|
3docSec changed the severity to G (Gas Optimization) |
c4-judge
added
downgraded by judge
|
3docSec marked the issue as grade-b |
stevieraykatz
added a commit
to coinbase/smart-wallet
that referenced
this issue
Apr 3, 2024
stevieraykatz
added a commit
to coinbase/smart-wallet
that referenced
this issue
Apr 4, 2024
* Leverage solidity overflow check optimization for loop index increment. code-423n4/2024-03-coinbase-findings#38 * Cache storage var for use in loop, update once at the end. Per code-423n4/2024-03-coinbase-findings#195, G-01 * Cache storage pointer and reference in intialization. Per code-423n4/2024-03-coinbase-findings#195, G-02 * Remove no-op assigning of default value. Per code-423n4/2024-03-coinbase-findings#195 G-09 * Add new gas snapshot * Revert erc1271 change * Rerun snapshot * Remove _addOwner method and call _addOwnerAtIndex directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lines of code
https://github.com/code-423n4/2024-03-coinbase/blob/e0573369b865d47fed778de00a7b6df65ab1744e/src/SmartWallet/CoinbaseSmartWallet.sol#L208-L210
Vulnerability details
Impact
The new optimization in v0.8.22 removes the need for poor unchecked increment patterns in for loop bodies such
Proof of Concept
Solidity 0.8.22 introduces an overflow check optimization that automatically generates an unchecked arithmetic increment of the counter of for loops.
Tools Used
manual
Recommended Mitigation Steps
do not use
++iin>v0.8.22Assessed type
Other
The text was updated successfully, but these errors were encountered: