Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check for sequencer uptime will lead dutch auctions executing at worst prices #174

Closed
c4-bot-9 opened this issue Aug 19, 2024 · 0 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-94 🤖_33_group AI based duplicate group recommendation sufficient quality report This report is of sufficient quality

Comments

@c4-bot-9
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/plugins/trading/DutchTrade.sol#L91

Vulnerability details

Dutch auctions allow the protocol to sell assets at a time based decreasing price, which means means the longer the auction the lower the price.
This kind of model presents some risk if the sequencer on L2 chains fails to work properly after the auction has been fired.

Impact

The impact is financial, dutch auctions will be less profitable for the protocol.

Proof of Concept

Given that the price during dutch auctions is based on how much time has passed since the start.

   uint192 price = _price(uint48(block.timestamp)); 

A network outage can be quite damaging to any actors providing liquidity to the system.

Consider the following scenario.

A 30 min long dutch auction start
The network experiences an outage, causing the sequencer to go offline.
45 min later the network is back
A fast actor bids on the dutch auction sitting now at the worst price
Auction settles.

Tools Used

Manuel reviews

Recommended Mitigation Steps

With the use of Chainlinks sequencer uptime feeds, negate auctions that have been taking place while an outage.

Assessed type

Other

@c4-bot-9 c4-bot-9 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Aug 19, 2024
c4-bot-2 added a commit that referenced this issue Aug 19, 2024
@c4-bot-12 c4-bot-12 added the 🤖_33_group AI based duplicate group recommendation label Aug 19, 2024
howlbot-integration bot added a commit that referenced this issue Aug 20, 2024
@howlbot-integration howlbot-integration bot added sufficient quality report This report is of sufficient quality duplicate-94 labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-94 🤖_33_group AI based duplicate group recommendation sufficient quality report This report is of sufficient quality
Projects
None yet
Development

No branches or pull requests

2 participants