-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-jsdocs): add plugin-jsdocs to analyze documentation in ts/js projects #896
feat(plugin-jsdocs): add plugin-jsdocs to analyze documentation in ts/js projects #896
Conversation
Code PushUp😟 Code PushUp report has regressed – compared target commit 053d595 with source commit 053d595. 🏷️ Categories👎 1 group regressed, 👎 5 audits regressed, 13 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits570 other audits are unchanged. |
…anced and some code improved
…ls. Solid version working
…te unit test for runner file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, this plugin looks really promising ❤️
My main quibble is with the outer namings, but also left some suggestions for the source code.
packages/plugin-doc-coverage/src/lib/runner/doc-processer.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/plugin-doc-coverage/src/lib/runner/runner.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Hey @matejchalk ! Every comment has been reviewed, 99% of them just applied as u said, except one that I had to do differently. Thank you so much for the deep review! ^^ |
packages/plugin-jsdocs/src/lib/runner/__snapshots__/doc-processer.unit.test.ts.snap
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <[email protected]>
@matejchalk Done for now, thanks again for the review ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏 Thanks for the updates 👍
WONDERFUL!!!!! |
This PR includes:
Closes #908
Report Summary
Overview of Audit Groups, Audit Counts, and Diagnostic Issue Types.
classes-coverage
,methods-coverage
,functions-coverage
,interfaces-coverage
,variables-coverage
,properties-coverage
,types-coverage
,enums-coverage