Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-eslint): add support for custom groups #925

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

hanna-skryl
Copy link
Collaborator

Closes #897

This PR introduces support for custom groups in the ESLint plugin, enabling users to define and categorize ESLint rules with custom weights and configurations.

@hanna-skryl hanna-skryl self-assigned this Jan 22, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 eslint-plugin 🛠️ tooling labels Jan 22, 2025
@hanna-skryl hanna-skryl marked this pull request as ready for review January 23, 2025 00:08
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really looking forward to this feature 🚀

Implementation overall looks good and is very well tested 👍

Left a few suggestions.

packages/plugin-eslint/README.md Outdated Show resolved Hide resolved
packages/plugin-eslint/src/lib/meta/groups.ts Show resolved Hide resolved
packages/plugin-eslint/src/lib/meta/groups.ts Outdated Show resolved Hide resolved
packages/plugin-eslint/src/lib/meta/groups.unit.test.ts Outdated Show resolved Hide resolved
@hanna-skryl hanna-skryl force-pushed the feat/custom-eslint-groups branch 2 times, most recently from 0395ac3 to de1a63e Compare January 23, 2025 20:58
Copy link

github-actions bot commented Jan 23, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 0101cfe with source commit b230a3d.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🔴 47 ↓ −5
Documentation 🔴 23 🔴 23 ↓ −0.4
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 81 🟡 81
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 3 groups regressed, 👍 1 audit improved, 👎 11 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🔴 47 ↓ −5
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.4
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.6 s 🟥 7.1 s ↑ +27 %
Lighthouse Largest Contentful Paint 🟨 3.5 s 🟨 3.8 s ↑ +9 %
Lighthouse Time to Interactive 🟥 13.4 s 🟥 15.0 s ↑ +11.9 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.9 s ↑ +3.4 %
JSDoc coverage Classes coverage 🟥 6 undocumented classes 🟥 7 undocumented classes ↑ +16.7 %
Lighthouse Total Blocking Time 🟥 3,490 ms 🟥 6,810 ms ↑ +95 %
Code coverage Function coverage 🟩 93.3 % 🟩 93.1 % ↓ −0.2 %
JSDoc coverage Types coverage 🟥 195 undocumented types 🟥 198 undocumented types ↑ +1.5 %
Code coverage Branch coverage 🟨 86 % 🟨 86.1 % ↑ +0.1 %
JSDoc coverage Functions coverage 🟥 432 undocumented functions 🟥 437 undocumented functions ↑ +1.2 %
Code coverage Line coverage 🟩 90.1 % 🟩 90.1 % ↓ −0.1 %
JSDoc coverage Variables coverage 🟥 193 undocumented variables 🟥 196 undocumented variables ↑ +1.6 %
Lighthouse Minimizes main-thread work 🟥 13.5 s 🟥 19.1 s ↑ +42.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,821 KiB 🟩 Total size was 1,817 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 5.8 s 🟥 8.7 s ↑ +49.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +11.9 %
Lighthouse Max Potential First Input Delay 🟥 2,000 ms 🟥 2,490 ms ↑ +24.6 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 680 ms 🟥 Potential savings of 390 ms ↓ −43.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 190 ms 🟩 240 ms ↑ +25.6 %
Lighthouse Initial server response time was short 🟥 Root document took 670 ms 🟥 Root document took 680 ms ↑ +2.6 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 70 ms ↓ −2.9 %

574 other audits are unchanged.

@hanna-skryl hanna-skryl force-pushed the feat/custom-eslint-groups branch from de1a63e to 08e02e9 Compare January 24, 2025 16:03
@hanna-skryl hanna-skryl merged commit ec834db into main Jan 24, 2025
16 checks passed
@hanna-skryl hanna-skryl deleted the feat/custom-eslint-groups branch January 24, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom groups for ESLint plugin
2 participants