Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the reusability of the middleware by passing all headers ins… #3

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

yannicschroeer
Copy link
Collaborator

Passing all headers instead of just the "Authorization" to the verification method in order to improve reusability and extensibility

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #3 (e1fc6db) into oauth2autobackend (1c0473e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           oauth2autobackend        #3   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
===================================================
  Files                      3         3           
  Lines                    123       122    -1     
===================================================
- Hits                     123       122    -1     
Impacted Files Coverage Δ
fastapi_auth_middleware/middleware.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0473e...e1fc6db. Read the comment docs.

Base automatically changed from oauth2autobackend to main March 14, 2022 20:47
Copy link
Collaborator

@JonasScholl JonasScholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Time for the next minor version :D

@yannicschroeer yannicschroeer merged commit 56ef630 into main Mar 15, 2022
@yannicschroeer yannicschroeer deleted the improveReuse branch March 15, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants