Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for Yt share options links #31

Closed

Conversation

gravit09
Copy link

->Fixed the issue of not working for videos which have link in this format :- https://youtu.be/GhH1QWY6BDc?feature=shared
-> Added the functionality so that thumbnail and video get played for both type of YouTube URL.
->Also disabled the add to queue button if no input is present there.

@hkirat
Copy link
Contributor

hkirat commented Aug 30, 2024

remove package-lock

@gravit09
Copy link
Author

gravit09 commented Aug 30, 2024

remove package-lock

@hkirat done

@gravit09
Copy link
Author

gravit09 commented Sep 1, 2024

btw

https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

@Parikshit2001 so should i keep package lock json but he mentioned to remove it.

@thepradipvc
Copy link
Contributor

Hey @gravit09
The lock file is supposed to be kept in git but we are using pnpm as a package manager so we have pnpm-lock.json
And you should only commit pnpm-lock.json file when you have removed or installed a new package.

@gravit09
Copy link
Author

Hey @gravit09 The lock file is supposed to be kept in git but we are using pnpm as a package manager so we have pnpm-lock.json And you should only commit pnpm-lock.json file when you have removed or installed a new package.

I have already removed the pnpm-lock.json file. Could there be any other issues preventing my pull request from being merged?

@thepradipvc
Copy link
Contributor

The app structure has been changed so you'll have to merge it first in your branch and then resolve conflicts if any first.

@gravit09 gravit09 closed this Sep 11, 2024
@gravit09 gravit09 force-pushed the bug-notWorkingForSharedLinkFixed branch from fccd06e to f3d84aa Compare September 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants