fix: handle YouTube URLs in any format to correctly extract video ID #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix the lint |
|
Ideally this is a few line changes. Please open a new PR without the lints |
|
Sure |
Manoo07
force-pushed
the
fix/youtube-url
branch
from
8795e58 to
41d1b87
Compare
|
Hey @SujithThirumalaisamy ,I have fixed the lint Please review |
Manoo07
force-pushed
the
fix/youtube-url
branch
from
41d1b87 to
f3fd940
Compare
next-app/app/api/streams/route.ts
Outdated
| @@ -55,7 +55,7 @@ export async function POST(req: NextRequest) { | |||
| ); | |||
| } | |||
|
|
|||
| const extractedId = data.url.split("?v=")[1]; | |||
| const extractedId = data.url.split("?v=")[1].split("&")[0]; | |||
There was a problem hiding this comment.
This will fail for shorterned links like https://youtu.be/dQw4w9WgXcQ
There was a problem hiding this comment.
Hey @SujithThirumalaisamy ,Thanks for pointing that out.
This should now correctly handle both standard and shortened YouTube URLs. Please test it with different URL formats and let me know if there are any other issues.
|
Merging this for now. Can fix if there are something more. I think of nothing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12 , #32 , #33
This PR adds :
parameters,shortened links, orembedded formats.