Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work update of minicart's count #12

Closed
Mr-Bam opened this issue Feb 6, 2019 · 3 comments
Closed

Doesn't work update of minicart's count #12

Mr-Bam opened this issue Feb 6, 2019 · 3 comments

Comments

@Mr-Bam
Copy link

Mr-Bam commented Feb 6, 2019

I have condition when subtotal price will be more than 1500.
Problem is in when we add two products with price 849 (subtotal 1698), minicart count equal 2, but in general is 3, because we have add free product by condition. Also, if we add one product more, than it updates well. After that if we want to do subtotal price less then 1500, our free product will remove from cart, but count of minicart will not update.
So, I think that we have to do update of minicart count every time when we add free product or remove.
I have thought it can be in FreeProduct\Observer\RemoveGiftItems.php. But, unfortunately, I can't understand how to do it only by php without js.
Here is screenshots:
Here is correct
image
Here is wrong showing
image
Here is again correct
image
If we change qty of product to 1, we have the same situation like in the first screen.

@domeglic
Copy link
Contributor

domeglic commented Feb 6, 2019

There is a new version in develop branch that we are currently testing that should fix this problem.

@Mr-Bam
Copy link
Author

Mr-Bam commented Feb 7, 2019 via email

domeglic added a commit that referenced this issue Feb 8, 2019
Fix for #9 and #12. New feature: apply gift for each subset of products, multiple gifts per rule
@domeglic
Copy link
Contributor

domeglic commented Feb 8, 2019

Should be fixed by #13

@domeglic domeglic closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants